Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): add pytest topology mark for test_srv6_basic_sanity test #16545

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

LARLSN
Copy link
Contributor

@LARLSN LARLSN commented Jan 16, 2025

Description of PR

add ciscovs-7nodes and ciscovs-5nodes pytest topology marker for test_srv6_basic_sanity test
to fix issue #15561
Summary:
Fixes # (issue)15561

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. @wangxin , can you please merge it?

@abdosi
Copy link
Contributor

abdosi commented Jan 21, 2025

please resolve conflict.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LARLSN
Copy link
Contributor Author

LARLSN commented Jan 22, 2025

please resolve conflict.

Resolved

@BYGX-wcr
Copy link
Contributor

@abdosi , the conflict has been resolved. Let's merge and close this one?

@abdosi abdosi merged commit 1934bee into sonic-net:master Jan 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants